This should be the heyday of the National Rifle Association. As its members gather at the legendary gun group’s annual conference in St. Louis, the state of gun rights has never been better.